From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Subject: Re: [PATCH] rte_memory.h: include stdio.h for FILE
Date: Fri, 27 Jun 2014 02:11:19 +0200 [thread overview]
Message-ID: <1465279.oYkyYahRlY@xps13> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
> The below commit requires stdio FILE structure.
>
> commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
> Author: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> Date: Fri May 2 16:42:56 2014 -0700
>
> add FILE argument to debug functions
>
> Application which includes rte_memory.h without stdio.h will be hit
> compilation failure.
>
> /path/to/include/rte_memory.h:146:30: error: unknown type name ‘FILE’
> void rte_dump_physmem_layout(FILE *f);
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied for version 1.7.0.
Thanks
--
Thomas
prev parent reply other threads:[~2014-06-27 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 8:10 [PATCH] rte_memory.h: include stdio.h for FILE Hiroshi Shimamoto
[not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-06-17 3:48 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F210465-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-25 9:51 ` Thomas Monjalon
2014-06-27 0:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465279.oYkyYahRlY@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
--cc=h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).