From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] ip_pipeline: add flow actions pipeline Date: Mon, 07 Dec 2015 12:57:56 +0100 Message-ID: <1465661.sXytVPa95X@xps13> References: <1447866563-19121-1-git-send-email-roy.fan.zhang@intel.com> <1584130.bSMaiaJVtY@xps13> <566548AC.6020807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 5DEC695B7 for ; Mon, 7 Dec 2015 12:59:09 +0100 (CET) Received: by wmec201 with SMTP id c201so147515598wme.1 for ; Mon, 07 Dec 2015 03:59:09 -0800 (PST) In-Reply-To: <566548AC.6020807@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-07 10:51, Panu Matilainen: > On 12/07/2015 03:17 AM, Thomas Monjalon wrote: > > 2015-11-18 17:09, Fan Zhang: > >> Flow actions pipeline is an extension of flow-classification pipeline. > >> Some of the operations of flow classification pipeline such as traffic > >> metering/marking(for e.g. Single Rate Three Color Marker (srTCM), Two > >> Rate Three Color Marker trTCM)), policer can be performed separately in > >> flow action pipeline to avoid excessive computational burden on the CPU > >> core running the flow-classification pipeline. The Flow action pipeline > >> implements various function such as traffic metering, policer, stats. > >> Traffic mettering can configured as per the required context, for > >> examples- per user, per traffic class or both. These contexts can be > >> applied by specifying parameters in configuration file as shown below; > >> > >> [PIPELINE1] > >> type = FLOW_ACTIONS > >> core = 1 > >> pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0 > >> pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 > >> n_flows = 65536 > >> n_meters_per_flow = 1 > >> flow_id_offset = 158 > >> ip_hdr_offset = 142 > >> color_offset = 64 > >> > >> The entries of flow and dscp tables of flow actions pipeline can be > >> modified through command-line interface. The commands to add or delete > >> entries to the flow table, DSCP(differentiated services code point) > >> table and for statistics collection, etc have been included. The key > >> functions such as Traffic Metering/marking and policer functions have > >> been implemented as flow-table action handler. > >> > >> Signed-off-by: Jasvinder Singh > >> Signed-off-by: Fan Zhang > >> Acked-by: Cristian Dumitrescu > > > > Applied, thanks > > > > The patch tries to include pipeline_flow_actions.h which doesn't exist, > making the ip_pipeline example unbuildable. > > Seems like a case of forgotten "git add" when creating the patch... Yes you are right. My bad. I had to resolve some conflicts and forgot these "git add". It is fixed now. Thank you for reporting.