From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rugang Chen Subject: [PATCH] pci:don't insert an unbound device to pci_device_list in pci_scan_one Date: Fri, 24 Jun 2016 17:45:28 -0700 Message-ID: <1466815528-27163-1-git-send-email-rugangchen2011@gmail.com> Cc: Rugang Chen To: dev@dpdk.org Return-path: Received: from mail-pa0-f67.google.com (mail-pa0-f67.google.com [209.85.220.67]) by dpdk.org (Postfix) with ESMTP id 9D9B8C618 for ; Sat, 25 Jun 2016 02:45:37 +0200 (CEST) Received: by mail-pa0-f67.google.com with SMTP id us13so10180370pab.1 for ; Fri, 24 Jun 2016 17:45:37 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If a device isn't bound by any uio driver (vfio-pci, igb_uio, uio_pci_generic) and is expected to owned by a kernel space driver, here it's still inserted to pci_device_list. This may cause application based on dpdk fetch the device by accident and then the device is hanlded by dpdk. For safe, skip it from pci_device_list as if it's unbound, dpdk won't want to use it. Signed-off-by: Rugang Chen --- lib/librte_eal/linuxapp/eal/eal_pci.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index f9c3efd..f63febc 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -388,6 +388,12 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus, } else dev->kdrv = RTE_KDRV_NONE; + /* Ignore device that isn't bound with any uio driver, then application won't + * fetch it from pci_device_list by accident and then dpdk handles it. Kernel + * space driver maybe wants to own it. + */ + if (dev->kdrv == RTE_KDRV_NONE) + return 0; /* device is valid, add in list (sorted) */ if (TAILQ_EMPTY(&pci_device_list)) { TAILQ_INSERT_TAIL(&pci_device_list, dev, next); -- 2.1.4