From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH v2 7/7] mk: check shared library dependencies Date: Sun, 26 Jun 2016 18:42:05 +0200 Message-ID: <1466959325-9426-8-git-send-email-thomas.monjalon@6wind.com> References: <1466959325-9426-1-git-send-email-thomas.monjalon@6wind.com> Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C6AB9694A for ; Sun, 26 Jun 2016 18:42:17 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id v199so73582849wmv.0 for ; Sun, 26 Jun 2016 09:42:17 -0700 (PDT) In-Reply-To: <1466959325-9426-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Panu Matilainen Require all symbols used by a DSO to be resolvable via LDLIBS at build-time. Previously it was possible to build a library with incomplete dependencies which could then fail at run-time. Signed-off-by: Panu Matilainen --- mk/rte.lib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 924dfb5..0187ae8 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -94,7 +94,7 @@ O_TO_A_DO = @set -e; \ echo $(O_TO_A_CMD) > $(call exe2cmd,$(@)) O_TO_S = $(LD) -L$(RTE_SDK_BIN)/lib $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) \ - -shared $(OBJS-y) $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB) + -shared $(OBJS-y) -z defs $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB) O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") O_TO_S_DO = @set -e; \ -- 2.7.0