From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH v2] net/ixgbe: fix compilation when offload flags disabled Date: Fri, 1 Jul 2016 10:02:27 +0200 Message-ID: <1467360147-19571-1-git-send-email-olivier.matz@6wind.com> References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: amint@icsi.berkeley.edu To: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 39BEB2B91 for ; Fri, 1 Jul 2016 10:02:50 +0200 (CEST) In-Reply-To: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=3D= n because the macro has not the proper number of parameters. To reproduce the issue: make config T=3Dx86_64-native-linuxapp-gcc sed -i 's,CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=3Dy,CONFIG_RTE_IXGBE_RX_OL= FLAGS_ENABLE=3Dn,' build/.config make -j4 [...] ixgbe_rxtx_vec_sse.c: In function =E2=80=98_recv_raw_pkts_vec=E2=80=99= : ixgbe_rxtx_vec_sse.c:345:53: error: macro "desc_to_olflags_v" passed 3= arguments, but takes just 2 desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); ^ ixgbe_rxtx_vec_sse.c:345:3: error: =E2=80=98desc_to_olflags_v=E2=80=99= undeclared (first use in this function) desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); ^ ixgbe_rxtx_vec_sse.c:345:3: note: each undeclared identifier is report= ed only once for each function it appears in ixgbe_rxtx_vec_sse.c:231:10: error: variable =E2=80=98vlan_flags=E2=80= =99 set but not used [-Werror=3Dunused-but-set-variable] uint8_t vlan_flags; ^ cc1: all warnings being treated as errors This patch fixes the number of arguments in th macro, and ensure that vlan_flags is marked as used to avoid the third error. Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") Reported-by: Amin Tootoonchian Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/i= xgbe_rxtx_vec_sse.c index 4f95deb..1c4fd7c 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c @@ -197,7 +197,9 @@ desc_to_olflags_v(__m128i descs[4], uint8_t vlan_flag= s, rx_pkts[3]->ol_flags =3D vol.e[3]; } #else -#define desc_to_olflags_v(desc, rx_pkts) do {} while (0) +#define desc_to_olflags_v(desc, vlan_flags, rx_pkts) do { \ + RTE_SET_USED(vlan_flags); \ + } while (0) #endif =20 /* --=20 2.8.1