From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Maximets Subject: [PATCH] app/testpmd: refactor of RSS fwd config Date: Tue, 05 Jul 2016 10:20:26 +0300 Message-ID: <1467703226-11836-1-git-send-email-i.maximets@samsung.com> Cc: Dyasly Sergey , Heetae Ahn , Zhihong Wang , Ilya Maximets To: dev@dpdk.org, Pablo de Lara Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 3DF192C17 for ; Tue, 5 Jul 2016 09:20:40 +0200 (CEST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9T005XXZ2EA630@mailout4.w1.samsung.com> for dev@dpdk.org; Tue, 05 Jul 2016 08:20:38 +0100 (BST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since commit f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup") behavior of rss_fwd_config_setup() changed and description of this function is wrong now. Also, there is a type mismatch in a loop. Signed-off-by: Ilya Maximets --- app/test-pmd/config.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index c5865f9..bfcbff9 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1201,14 +1201,9 @@ simple_fwd_config_setup(void) } /** - * For the RSS forwarding test, each core is assigned on every port a transmit - * queue whose index is the index of the core itself. This approach limits the - * maximumm number of processing cores of the RSS test to the maximum number of - * TX queues supported by the devices. - * - * Each core is assigned a single stream, each stream being composed of - * a RX queue to poll on a RX port for input messages, associated with - * a TX queue of a TX port where to send forwarded packets. + * For the RSS forwarding test all streams distributed over lcores. Each stream + * being composed of a RX queue to poll on a RX port for input messages, + * associated with a TX queue of a TX port where to send forwarded packets. * All packets received on the RX queue of index "RxQj" of the RX port "RxPi" * are sent on the TX queue "TxQl" of the TX port "TxPk" according to the two * following rules: @@ -1222,7 +1217,7 @@ rss_fwd_config_setup(void) portid_t txp; queueid_t rxq; queueid_t nb_q; - lcoreid_t lc_id; + streamid_t sm_id; nb_q = nb_rxq; if (nb_q > nb_txq) @@ -1241,10 +1236,10 @@ rss_fwd_config_setup(void) setup_fwd_config_of_each_lcore(&cur_fwd_config); rxp = 0; rxq = 0; - for (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_streams; lc_id++) { + for (sm_id = 0; sm_id < cur_fwd_config.nb_fwd_streams; sm_id++) { struct fwd_stream *fs; - fs = fwd_streams[lc_id]; + fs = fwd_streams[sm_id]; if ((rxp & 0x1) == 0) txp = (portid_t) (rxp + 1); -- 2.7.4