From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas.monjalon@6wind.com, Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] scripts: add check for net driver names without net prefix
Date: Tue, 5 Jul 2016 15:40:50 +0100 [thread overview]
Message-ID: <1467729650-925-1-git-send-email-bruce.richardson@intel.com> (raw)
Since the current standard for commit prefixes is to put the device type
e.g. "net", in front of the driver name, add a check for commit titles
which have a net driver name without any prefix in front of it.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
scripts/check-git-log.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 7d2c7ee..7dc1fd8 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -78,6 +78,12 @@ bad=$(echo "$headlines" | grep --color=always \
| sed 's,^,\t,')
[ -z "$bad" ] || printf "Wrong headline label:\n$bad\n"
+# check headline label for net/ prefix if needed
+bad=$(echo "$headlines" | grep -E --color=always \
+ -e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \
+ | sed 's,^,\t,')
+[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n"
+
# check headline lowercase for first words
bad=$(echo "$headlines" | grep --color=always \
-e '^.*[A-Z].*:' \
--
2.5.5
next reply other threads:[~2016-07-05 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 14:40 Bruce Richardson [this message]
2016-07-06 9:10 ` [PATCH] scripts: add check for net driver names without net prefix Thomas Monjalon
2016-07-06 9:25 ` Bruce Richardson
2016-07-06 9:46 ` Thomas Monjalon
2016-07-06 10:28 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467729650-925-1-git-send-email-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).