From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH 1/3] scripts: check spacing after commit references Date: Wed, 6 Jul 2016 12:38:48 +0200 Message-ID: <1467801530-20800-2-git-send-email-thomas.monjalon@6wind.com> References: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 629F76CA4 for ; Wed, 6 Jul 2016 12:38:59 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id 187so31673781wmz.1 for ; Wed, 06 Jul 2016 03:38:59 -0700 (PDT) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id x194sm3381094wmf.13.2016.07.06.03.38.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Jul 2016 03:38:58 -0700 (PDT) In-Reply-To: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A blank line between "Fixes" and "Signed-off-by" helps to separate information in blocks. Signed-off-by: Thomas Monjalon --- scripts/check-git-log.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh index c7fc0e4..a24f101 100755 --- a/scripts/check-git-log.sh +++ b/scripts/check-git-log.sh @@ -129,6 +129,12 @@ bad=$(echo "$tags" | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" +# check blank line after last Fixes: tag +bad=$(echo "$bodylines" | + sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' | + sed 's,^.,\t&,') +[ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n" + # check missing Fixes: tag bad=$(for fix in $fixes ; do git log --format='%b' -1 $fix | grep -q '^Fixes: ' || -- 2.7.0