From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: [PATCH] net/virtio-user: Fix missing brackets in if condition Date: Tue, 12 Jul 2016 11:30:25 +0200 Message-ID: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Maxime Coquelin , Jianfeng Tan To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6A71CF94 for ; Tue, 12 Jul 2016 11:30:42 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The error is reported using test build script: $ scripts/test-build.sh x86_64-native-linuxapp-gcc ... drivers/net/virtio/virtio_user_ethdev.c: In function =E2=80=98virtio_user= _pmd_devinit=E2=80=99: drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this =E2=80=98if=E2= =80=99 clause does not guard... [-Werror=3Dmisleading-indentation] if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1) ^~ Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked") Cc: Jianfeng Tan Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio= /virtio_user_ethdev.c index 782d7d3..6b4f66e 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -342,7 +342,7 @@ virtio_user_pmd_devinit(const char *name, const char = *params) goto end; } =20 - if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1) + if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1) { ret =3D rte_kvargs_process(kvlist, VIRTIO_USER_ARG_PATH, &get_string_arg, &path); if (ret < 0) { @@ -350,7 +350,7 @@ virtio_user_pmd_devinit(const char *name, const char = *params) VIRTIO_USER_ARG_PATH); goto end; } - else { + } else { PMD_INIT_LOG(ERR, "arg %s is mandatory for virtio-user\n", VIRTIO_USER_ARG_QUEUE_SIZE); goto end; --=20 2.7.4