From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] hash: move rte_hash structure to C file and make it internal Date: Fri, 10 Jul 2015 12:27:50 +0200 Message-ID: <1468321.xAuDIq3Hpb@xps13> References: <1436354854-30700-1-git-send-email-pablo.de.lara.guarch@intel.com> <1436354854-30700-2-git-send-email-pablo.de.lara.guarch@intel.com> <20150708132142.GB5708@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id C20F55A72 for ; Fri, 10 Jul 2015 12:28:58 +0200 (CEST) Received: by wifm2 with SMTP id m2so42404886wif.1 for ; Fri, 10 Jul 2015 03:28:58 -0700 (PDT) In-Reply-To: <20150708132142.GB5708@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-08 14:21, Bruce Richardson: > On Wed, Jul 08, 2015 at 12:27:34PM +0100, Pablo de Lara wrote: > > rte_hash structure should not be a public structure, > > and therefore it should be moved to the C file and be declared > > as internal. rte_hash_hash implementation is also moved > > to the C file, as it uses the structure. > > > > This patch also removes part of a unit test that was checking > > a field of the structure. > > > > Signed-off-by: Pablo de Lara > > Irrespective of whether or not we change the underlying hash table implementation > this looks a good change to me. The rte_hash structure should not be used directly > by any applications - the APIs all take pointers to the structure, > so there should be no ABI breakage from this, I think. > > Therefore: > > Acked-by: Bruce Richardson Applied, thanks