From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code Date: Fri, 15 Jul 2016 14:33:42 -0400 Message-ID: <1468607622.1732.4.camel@gmail.com> References: <1468330694-383-2-git-send-email-3chas3@gmail.com> <20160715155615.GB51144@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, harish.patil@qlogic.com To: Bruce Richardson Return-path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id 75A1A9E7 for ; Fri, 15 Jul 2016 20:33:44 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id p126so1685932qke.1 for ; Fri, 15 Jul 2016 11:33:44 -0700 (PDT) In-Reply-To: <20160715155615.GB51144@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 2016-07-15 at 16:56 +0100, Bruce Richardson wrote: > On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote: > > ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined.=C2=A0=C2= =A0Remove them > > along with enumeration constants dependent on their inclusion. > >=C2=A0 > > Fixes: 540a211084a7 ("bnx2x: driver core") > >=C2=A0 > > Signed-off-by: Chas Williams <3chas3@gmail.com> >=20 > Hi Chas, >=20 > the threading on this submission is very awkward - poor patch 1 got som= ehow > separated from the rest of it's patch family. :-) Yeah, I don't know what happened there. > Besides this, given where we are in the release cycle for 16.07, these = cleanups > are being deferred for possible inclusion in 16.11 (once reviewed and a= cked, > obviously). To get cleanup like this in in future release, please submi= t by > the integration deadline date. Not a problem. =C2=A0These are not urgent changes. =C2=A0There are some real issues fixed but I suspect no one runs into them.