From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] app/test: disable filtering with stripped binary Date: Tue, 19 Jul 2016 18:53:50 +0200 Message-ID: <1468947230-22874-1-git-send-email-thomas.monjalon@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id BDF782B86 for ; Tue, 19 Jul 2016 18:53:58 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id i5so33940843wmg.0 for ; Tue, 19 Jul 2016 09:53:58 -0700 (PDT) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b130sm24337097wmg.3.2016.07.19.09.53.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jul 2016 09:53:57 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The unavailable tests are filtered out by autotest by looking for the symbols in the binary: PCI autotest: Skipped [Not Available] [00m 00s] Malloc autotest: Success [00m 00s] It results to skip everything if the binary has no symbol (stripped): PCI autotest: Skipped [Not Available] [00m 00s] Malloc autotest: Skipped [Not Available] [00m 00s] This case is handled by getting back to the old behaviour if the binary has no symbol information: PCI autotest: Fail [Not found] [00m 00s] Malloc autotest: Success [00m 00s] Fixes: d553c8f2b1a2 ("app/test: filter out unavailable tests") Signed-off-by: Thomas Monjalon --- app/test/autotest_runner.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py index bd99e19..21d3be2 100644 --- a/app/test/autotest_runner.py +++ b/app/test/autotest_runner.py @@ -107,8 +107,10 @@ def run_test_group(cmdline, test_group): # parse the binary for available test commands binary = cmdline.split()[0] - symbols = subprocess.check_output(['nm', binary]).decode('utf-8') - avail_cmds = re.findall('test_register_(\w+)', symbols) + stripped = 'not stripped' not in subprocess.check_output(['file', binary]) + if not stripped: + symbols = subprocess.check_output(['nm', binary]).decode('utf-8') + avail_cmds = re.findall('test_register_(\w+)', symbols) # run all tests in test group for test in test_group["Tests"]: @@ -129,7 +131,7 @@ def run_test_group(cmdline, test_group): print >>logfile, "\n%s %s\n" % ("-"*20, test["Name"]) # run test function associated with the test - if test["Command"] in avail_cmds: + if stripped or test["Command"] in avail_cmds: result = test["Func"](child, test["Command"]) else: result = (0, "Skipped [Not Available]") -- 2.7.0