From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Wang Subject: [PATCH 12/39] net/ixgbe/base: clear page register in error path Date: Sat, 27 Aug 2016 23:47:55 +0800 Message-ID: <1472312902-16963-13-git-send-email-xiao.w.wang@intel.com> References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org, Xiao Wang To: wenzhuo.lu@intel.com Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B01375A17 for ; Sat, 27 Aug 2016 17:49:00 +0200 (CEST) In-Reply-To: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The error exit should at least try to set the page register to 0 since other code will assume that state. Signed-off-by: Xiao Wang --- drivers/net/ixgbe/base/ixgbe_x550.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index bf3da10..2cd5730 100644 --- a/drivers/net/ixgbe/base/ixgbe_x550.c +++ b/drivers/net/ixgbe/base/ixgbe_x550.c @@ -2349,6 +2349,7 @@ STATIC s32 ixgbe_reset_phy_m88(struct ixgbe_hw *hw) return ixgbe_setup_m88(hw); out: + hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0); hw->mac.ops.release_swfw_sync(hw, mask); return rc; } -- 1.9.3