From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Wang Subject: [PATCH 25/39] net/ixgbe/base: set default autoneg speed at reset Date: Sat, 27 Aug 2016 23:48:08 +0800 Message-ID: <1472312902-16963-26-git-send-email-xiao.w.wang@intel.com> References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org, Xiao Wang To: wenzhuo.lu@intel.com Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 426CC590E for ; Sat, 27 Aug 2016 17:49:29 +0200 (CEST) In-Reply-To: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch avoids the situation where we initialize adapter and not yet set up phy.autoneg_advertised speeds. In that case we could end up in having no autoneg speeds enabled and get no link until we reset link and set autoneg speeds correctly. Signed-off-by: Xiao Wang --- drivers/net/ixgbe/base/ixgbe_x550.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 3c19326..32759cc 100644 --- a/drivers/net/ixgbe/base/ixgbe_x550.c +++ b/drivers/net/ixgbe/base/ixgbe_x550.c @@ -2283,6 +2283,12 @@ STATIC s32 ixgbe_reset_phy_m88(struct ixgbe_hw *hw) hw->mac.ops.release_swfw_sync(hw, mask); + /* In case of first reset set advertised speeds to default value */ + if (!hw->phy.autoneg_advertised) + hw->phy.autoneg_advertised = IXGBE_LINK_SPEED_1GB_FULL | + IXGBE_LINK_SPEED_100_FULL | + IXGBE_LINK_SPEED_10_FULL; + return ixgbe_setup_m88(hw); out: -- 1.9.3