From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] mk: pass CROSS_COMPILE when compiling kernel
	modules
Date: Thu, 17 Apr 2014 15:38:06 +0200
Message-ID: <1472845.ooNuTRJrP7@xps13>
References: <1391791458-17601-1-git-send-email-aaro.koskinen@nsn.com>
 <2031701.DtHZU1GqtL@x220>
 <20140307133226.GV15431@ak-desktop.emea.nsn-net.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Aaro Koskinen <aaro.koskinen-OYasijW0DpE@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20140307133226.GV15431-wKwWf7Pro3RJlwZWLBHdvBaOaYmgohGe0e7PPNI6Mm0@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi,

2014-03-07 15:32, Aaro Koskinen:
> On Tue, Feb 25, 2014 at 10:55:36PM +0100, Thomas Monjalon wrote:
> > 07/02/2014 18:44, Aaro Koskinen :
> > > Pass CROSS_COMPILE to the kernel build system when compiling kernel
> > > modules. Although we export CC etc. the top level kernel Makefile will
> > > override the environment. As a result it will end up using wrong tools
> > > if cross-compilation is desired but CROSS_COMPILE is not set.
> > > 
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen-OYasijW0DpE@public.gmane.org>
> > 
> > Could you explain why it's needed ?
> > In a basic test, CC=$(CROSS)gcc in rte.vars.mk seems sufficient.
> 
> If you compile on 32-bit host to 64-bit target, the build fails with
> errors such as:
> 
> [...]include/linux/kernfs.h:331:1: note: expected 'const char *' but
> argument is of type 'const unsigned char *' kernfs_find_and_get(struct
> kernfs_node *kn, const char *name)
>  ^
> cc1: all warnings being treated as errors
> 
> Build with V=1 shows that following appears in the command line
> when compiling the kernel modules:
> 
> 	-isystem /usr/lib/gcc/i486-linux-gnu/4.8/include
> 
> With the patch this will be corrected to point to my target's sysroot:
> 
> 	-isystem /foo/bar/lib/gcc/x86_64-linux-gnu/4.8.2/include
> 
> And the build succeeds without any warnings.

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

It's applied for version 1.6.0r2.

Thanks
-- 
Thomas