From mboxrd@z Thu Jan 1 00:00:00 1970 From: Weiliang Luo Subject: [PATCH] mempool: fix corruption due to invalid handler Date: Thu, 8 Sep 2016 10:29:57 -0500 Message-ID: <1473348597-11904-1-git-send-email-droidluo@gmail.com> Cc: Weiliang Luo To: dev@dpdk.org Return-path: Received: from mail-pa0-f66.google.com (mail-pa0-f66.google.com [209.85.220.66]) by dpdk.org (Postfix) with ESMTP id 221A09E7 for ; Thu, 8 Sep 2016 17:31:00 +0200 (CEST) Received: by mail-pa0-f66.google.com with SMTP id ez1so2535884pab.3 for ; Thu, 08 Sep 2016 08:31:00 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When using rte_mempool_create(), the mempool handler is selected depending on the flags given by the user: - multi-consumer / multi-producer - multi-consumer / single-producer - single-consumer / multi-producer - single-consumer / single-producer The flags were not properly tested, resulting in the selection of sc/sp handler if sc/mp or mc/sp was asked. This can lead to corruption or crashes because the get/put operations are not atomic. Fixes: 449c49b93a6b ("mempool: support handler operations") Signed-off-by: Weiliang Luo Acked-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 2e28e2e..350d77a 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -879,7 +879,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size, * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to * set the correct index into the table of ops structs. */ - if (flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET)) + if ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET)) rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL); else if (flags & MEMPOOL_F_SP_PUT) rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL); -- 2.7.4 (Apple Git-66)