From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ixgbe: fix 82599 / 82598 register differences Date: Wed, 28 Oct 2015 15:05:44 +0100 Message-ID: <1476412.gWjkHWKLvT@xps13> References: <1443701571-7000-1-git-send-email-harry.van.haaren@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Van Haaren, Harry" Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 84DB08DAF for ; Wed, 28 Oct 2015 15:06:55 +0100 (CET) Received: by wmec75 with SMTP id c75so7919976wme.1 for ; Wed, 28 Oct 2015 07:06:55 -0700 (PDT) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Ixgbe based 82598 and 82599 have different priority recieve link-on register > > addresses. This is solved in base/ by providing in the PXONRXC and > > PXONXCNT as seperate macros. This patch ensures the correct address is > > read, avoiding reading garbage values. > > > > Also PXON2OFFCNT doesn't exist in 82598, so it is not read for that MAC. > > > > This issue has existed since the drivers were imported into DPDK, but was > > not easily discoverable as xstats were not available. > > Tested using testpmd> show port xstats all > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Harry van Haaren > Acked-by: Wenzhuo Lu Applied, thanks