From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/2] eal: fix symbol missing in version map Date: Wed, 25 Feb 2015 14:39:33 +0100 Message-ID: <1481785.S6qqJ57RgF@xps13> References: <1424835589-18122-1-git-send-email-cunming.liang@intel.com> <20150225123053.GA31224@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: <20150225123053.GA31224-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-25 07:30, Neil Horman: > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote: > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map. > > Thanks for the notification from Tetsuya Mukawa . > > > > Cunming Liang (2): > > eal/linux: fix symbol missing in version map > > eal/bsd: fix symbol missing in version map > > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ > > 2 files changed, 4 insertions(+) > > > > NAK > > This is the wrong way to fix this problem. Exporting global variables is > never a good solution when it can be helped. Instead, rte_socket id should be > made a non inline function and exported. Then the definition of > per_lcore_socket_id can be made private, protecting it from type changes. Neil, I applied the patches to fix compilation on HEAD. In case your comment makes sense, a cleanup would be appreciated. Thanks