[PATCH v1 0/2] eal: fix symbol missing in version map

[PATCH v1 0/2] eal: fix symbol missing in version map

[Cunming Liang]

These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>. 

Cunming Liang (2):
  eal/linux: fix symbol missing in version map
  eal/bsd: fix symbol missing in version map

 lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
 lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
 2 files changed, 4 insertions(+)

-- 
1.8.1.4

[PATCH v1 1/2] eal/linux: fix symbol missing in version map

[Cunming Liang]

As per_lcore__socket_id and rte_sys_gettid are missing in version map,
it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled.

Signed-off-by: Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index c207cee..17515a9 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -10,6 +10,7 @@ DPDK_2.0 {
 	pci_driver_list;
 	per_lcore__lcore_id;
 	per_lcore__rte_errno;
+	per_lcore__socket_id;
 	rte_cpu_check_supported;
 	rte_cpu_get_flag_enabled;
 	rte_cycles_vmware_tsc_map;
@@ -83,6 +84,7 @@ DPDK_2.0 {
 	rte_snprintf;
 	rte_strerror;
 	rte_strsplit;
+	rte_sys_gettid;
 	rte_thread_get_affinity;
 	rte_thread_set_affinity;
 	rte_vlog;
-- 
1.8.1.4

[PATCH v1 2/2] eal/bsd: fix symbol missing in version map

[Cunming Liang]

As per_lcore__socket_id and rte_sys_gettid are missing in version map,
it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled.

Signed-off-by: Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index c207cee..17515a9 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -10,6 +10,7 @@ DPDK_2.0 {
 	pci_driver_list;
 	per_lcore__lcore_id;
 	per_lcore__rte_errno;
+	per_lcore__socket_id;
 	rte_cpu_check_supported;
 	rte_cpu_get_flag_enabled;
 	rte_cycles_vmware_tsc_map;
@@ -83,6 +84,7 @@ DPDK_2.0 {
 	rte_snprintf;
 	rte_strerror;
 	rte_strsplit;
+	rte_sys_gettid;
 	rte_thread_get_affinity;
 	rte_thread_set_affinity;
 	rte_vlog;
-- 
1.8.1.4

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Tetsuya Mukawa]

On 2015/02/25 12:39, Cunming Liang wrote:
> These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>. 
>
> Cunming Liang (2):
>   eal/linux: fix symbol missing in version map
>   eal/bsd: fix symbol missing in version map
>
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
>  2 files changed, 4 insertions(+)
>
Hi Liang,

I've confirmed it works on my Linux environment.

Thanks,
Tetsuya

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Cunming Liang
> Sent: Wednesday, February 25, 2015 3:40 AM
> To: dev-VfR2kkLFssw@public.gmane.org
> Subject: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map
> 
> These two patches are the fixing for the compling error when
> CONFIG_RTE_BUILD_SHARED_LIB=y.
> The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing
> in the version map.
> Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>.
> 
> Cunming Liang (2):
>   eal/linux: fix symbol missing in version map
>   eal/bsd: fix symbol missing in version map
> 
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
>  2 files changed, 4 insertions(+)
> 

Series Acked-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Thomas Monjalon]

> > These two patches are the fixing for the compling error when
> > CONFIG_RTE_BUILD_SHARED_LIB=y.
> > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing
> > in the version map.
> > Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>.

Please use Reported-by: in such case.

Fixes: ef76436c6834 ("eal: get unique thread id")
Fixes: 9e29251b2afa ("eal: thread affinity API")

> > Cunming Liang (2):
> >   eal/linux: fix symbol missing in version map
> >   eal/bsd: fix symbol missing in version map

Merged together

> Series Acked-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied, thanks

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Neil Horman]

On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>. 
> 
> Cunming Liang (2):
>   eal/linux: fix symbol missing in version map
>   eal/bsd: fix symbol missing in version map
> 
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
>  2 files changed, 4 insertions(+)
> 
> -- 
> 1.8.1.4
> 
> 

NAK

This is the wrong way to fix this problem. Exporting global variables is
never a good solution when it can be helped.  Instead, rte_socket id should be
made a non inline function and exported.  Then the definition of
per_lcore_socket_id can be made private, protecting it from type changes.

Neil

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Thomas Monjalon]

2015-02-25 07:30, Neil Horman:
> On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> > Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>. 
> > 
> > Cunming Liang (2):
> >   eal/linux: fix symbol missing in version map
> >   eal/bsd: fix symbol missing in version map
> > 
> >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
> >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> 
> NAK
> 
> This is the wrong way to fix this problem. Exporting global variables is
> never a good solution when it can be helped.  Instead, rte_socket id should be
> made a non inline function and exported.  Then the definition of
> per_lcore_socket_id can be made private, protecting it from type changes.

Neil, I applied the patches to fix compilation on HEAD.
In case your comment makes sense, a cleanup would be appreciated.

Thanks

Re: [PATCH v1 0/2] eal: fix symbol missing in version map

[Neil Horman]

On Wed, Feb 25, 2015 at 02:39:33PM +0100, Thomas Monjalon wrote:
> 2015-02-25 07:30, Neil Horman:
> > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> > > Thanks for the notification from Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>. 
> > > 
> > > Cunming Liang (2):
> > >   eal/linux: fix symbol missing in version map
> > >   eal/bsd: fix symbol missing in version map
> > > 
> > >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
> > >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> > >  2 files changed, 4 insertions(+)
> > > 
> > 
> > NAK
> > 
> > This is the wrong way to fix this problem. Exporting global variables is
> > never a good solution when it can be helped.  Instead, rte_socket id should be
> > made a non inline function and exported.  Then the definition of
> > per_lcore_socket_id can be made private, protecting it from type changes.
> 
> Neil, I applied the patches to fix compilation on HEAD.
> In case your comment makes sense, a cleanup would be appreciated.
> 
> Thanks
> 
Sent. You and Cunming are CC-ed
Thanks
Neil