From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: [RFC 10/23] eal: Do not panic on log failures Date: Fri, 30 Dec 2016 10:26:07 -0500 Message-ID: <1483111580-5397-11-git-send-email-aconole@redhat.com> References: <1483111580-5397-1-git-send-email-aconole@redhat.com> To: dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 85A59559A for ; Fri, 30 Dec 2016 16:26:27 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 063657F359 for ; Fri, 30 Dec 2016 15:26:27 +0000 (UTC) Received: from dhcp-25-97.bos.redhat.com (unused [10.10.52.171] (may be forged)) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBUFQLte031288 for ; Fri, 30 Dec 2016 10:26:26 -0500 In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen. Return 'Operation Not Supported' in errno, and let the caller know this error occured. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index f996047..a23ba17 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -813,8 +813,11 @@ rte_eal_init(int argc, char **argv) rte_config_init(); - if (rte_eal_log_init(logid, internal_config.syslog_facility) < 0) - rte_panic("Cannot init logs\n"); + if (rte_eal_log_init(logid, internal_config.syslog_facility) < 0) { + RTE_LOG (ERR, EAL, "Cannot init logs\n"); + errno = ENOTSUP; + return -1; + } if (rte_eal_pci_init() < 0) rte_panic("Cannot init PCI\n"); -- 2.7.4