From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: tools brainstorming Date: Tue, 14 Apr 2015 17:24:11 +0200 Message-ID: <1483348.C8YyOOilOR@xps13> References: <3571725.20GtF5MAnU@xps13> <2232884.6IKBPajdgE@xps13> <20150414145255.GC3296@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <20150414145255.GC3296@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-04-14 15:52, Bruce Richardson: > On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote: > > When a consensus is done, it must be added with a patch with custom > > checkpatch addition. > > > My personal feeling is that we should try and keep checkpatch modifications to a > minimum. Right now, we can use checkpatch as-is from kernel.org, right? Yes that's something we have to discuss. It should be preferred to avoid "forking" checkpatch. At the moment, I'm using this configuration: options="$options --max-line-length=100" options="$options --show-types" options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ SPLIT_STRING,LINE_SPACING,NEW_TYPEDEFS,COMPLEX_MACRO" linux/scripts/checkpatch.pl $options I would like to submit a script to run checkpatch with DPDK configuration when the coding rules are clear. However, I've already seen some options which are not enough configurable (don't remember which one). For such corner case, I would see 3 solutions (from the most to the least desired): - submit a patch to allow more configuration to kernel.org - give up automatic handling of corner cases - maintain a fork in scripts/ directory