From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasesh Mody Subject: [PATCH v2 16/26] net/qede/base: add check for get nvm info return code Date: Wed, 4 Jan 2017 23:03:58 -0800 Message-ID: <1483599848-7714-17-git-send-email-rasesh.mody@cavium.com> References: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Rasesh Mody , , To: Return-path: Received: from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com [67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 376EBF920 for ; Thu, 5 Jan 2017 08:06:39 +0100 (CET) In-Reply-To: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fail ecore_get_hw_info() in case ecore_hw_get_nvm_info() fails. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index f29b3cd..0da95c6 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2755,7 +2755,7 @@ ecore_get_hw_info(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, /* Since all information is common, only first hwfns should do this */ if (IS_LEAD_HWFN(p_hwfn)) { rc = ecore_iov_hw_info(p_hwfn); - if (rc) + if (rc != ECORE_SUCCESS) return rc; } @@ -2769,12 +2769,17 @@ ecore_get_hw_info(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, ecore_hw_info_port_num(p_hwfn, p_ptt); #ifndef ASIC_ONLY - if (CHIP_REV_IS_ASIC(p_hwfn->p_dev)) + if (CHIP_REV_IS_ASIC(p_hwfn->p_dev)) { +#endif + rc = ecore_hw_get_nvm_info(p_hwfn, p_ptt); + if (rc != ECORE_SUCCESS) + return rc; +#ifndef ASIC_ONLY + } #endif - ecore_hw_get_nvm_info(p_hwfn, p_ptt); rc = ecore_int_igu_read_cam(p_hwfn, p_ptt); - if (rc) + if (rc != ECORE_SUCCESS) return rc; #ifndef ASIC_ONLY -- 1.7.10.3