From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasesh Mody <rasesh.mody@cavium.com>
Subject: [PATCH v2 02/26] net/qede/base: improve set field macro
Date: Wed, 4 Jan 2017 23:03:44 -0800
Message-ID: <1483599848-7714-3-git-send-email-rasesh.mody@cavium.com>
References: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Rasesh Mody <rasesh.mody@cavium.com>, <dev@dpdk.org>,
 <Dept-EngDPDKDev@cavium.com>
To: <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com
 [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id B1092F60E
 for <dev@dpdk.org>; Thu,  5 Jan 2017 08:06:28 +0100 (CET)
In-Reply-To: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Improve robustness of the SET_FIELD macro by using a mask.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/base/ecore.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h
index 907b35b..c9f3b00 100644
--- a/drivers/net/qede/base/ecore.h
+++ b/drivers/net/qede/base/ecore.h
@@ -80,7 +80,7 @@ enum ecore_nvm_cmd {
 #define SET_FIELD(value, name, flag)					\
 do {									\
 	(value) &= ~(name##_MASK << name##_SHIFT);			\
-	(value) |= (((u64)flag) << (name##_SHIFT));			\
+	(value) |= ((((u64)flag) & (u64)name##_MASK) << (name##_SHIFT));\
 } while (0)
 
 #define GET_FIELD(value, name)						\
-- 
1.7.10.3