From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wang Subject: [PATCH] net/i40e: remove redundant statement and braces Date: Mon, 9 Jan 2017 08:48:52 -0500 Message-ID: <1483969732-20073-1-git-send-email-wang.yong19@zte.com.cn> Cc: dev@dpdk.org, Yong Wang To: helin.zhang@intel.com, jingjing.wu@intel.com Return-path: Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 7660F98 for ; Mon, 9 Jan 2017 13:43:58 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function "reassemble_packets()", the statement "end = secondlast;" is redundant since there is another assignment "start = end = NULL;" 3 lines below. BTW, I removed the redundant braces in the conditional statement "if (end->data_len > rxq->crc_len)". Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_rxtx_vec_common.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h index 6cb5dce..02d834a 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_common.h +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h @@ -65,9 +65,9 @@ start->ol_flags = end->ol_flags; /* we need to strip crc for the whole packet */ start->pkt_len -= rxq->crc_len; - if (end->data_len > rxq->crc_len) { + if (end->data_len > rxq->crc_len) end->data_len -= rxq->crc_len; - } else { + else { /* free up last mbuf */ struct rte_mbuf *secondlast = start; @@ -77,7 +77,6 @@ end->data_len); secondlast->next = NULL; rte_pktmbuf_free_seg(end); - end = secondlast; } pkts[pkt_idx++] = start; start = end = NULL; -- 1.8.3.1