From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] devtools: fix lookup commit fixing a fix of many commits Date: Tue, 17 Jan 2017 15:53:05 +0100 Message-ID: <1484664785-26788-1-git-send-email-thomas.monjalon@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 204D02A62 for ; Tue, 17 Jan 2017 15:53:12 +0100 (CET) Received: by mail-lf0-f46.google.com with SMTP id k86so109628659lfi.0 for ; Tue, 17 Jan 2017 06:53:12 -0800 (PST) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v2sm910311ljb.44.2017.01.17.06.53.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jan 2017 06:53:10 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was a bug when looking at a commit fixing a commit which itself was fixing many commits: % devtools/git-log-fixes.sh 12ee45a36~..12ee45a36 devtools/git-log-fixes.sh: 96: local: 5499c1fc9baa: bad variable name In this case, the list of commits was not quoted in variable assignment. Signed-off-by: Thomas Monjalon --- devtools/git-log-fixes.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index 4824c7f..d590735 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -90,7 +90,7 @@ origin_version () # ... git rev-parse -q --verify $1 >&- || continue # get version of this bug origin local origver=$(commit_version $origin) - local roothashes=$(origin_filter $origin) + local roothashes="$(origin_filter $origin)" if [ -n "$roothashes" ] ; then # look chained fix of fix recursively local rootver="$(origin_version $roothashes)" -- 2.7.0