From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernard Iremonger Subject: [PATCH v5 3/3] app/testpmd: fix port stop Date: Wed, 25 Jan 2017 14:36:03 +0000 Message-ID: <1485354963-17326-4-git-send-email-bernard.iremonger@intel.com> References: <1484671162-18493-1-git-send-email-bernard.iremonger@intel.com> Cc: Bernard Iremonger To: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7414F5424 for ; Wed, 25 Jan 2017 15:36:19 +0100 (CET) In-Reply-To: <1484671162-18493-1-git-send-email-bernard.iremonger@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_eth_dev_stop function is not called if the port_status is not RTE_PORT_STARTED. This can happen if the rte_eth_dev_start function is called directly, ie not through the start_port function. Make sure rte_eth_dev_stop is always called in stop_port function. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index ed7d83c..2d0ca3f 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1490,13 +1490,13 @@ stop_port(portid_t pid) continue; } + rte_eth_dev_stop(pi); + port = &ports[pi]; if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STARTED, RTE_PORT_HANDLING) == 0) continue; - rte_eth_dev_stop(pi); - if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0) printf("Port %d can not be set into stopped\n", pi); -- 2.10.1