From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL Date: Mon, 23 Mar 2015 12:27:31 +0100 Message-ID: <14866342.VnQ1r1AyAo@xps13> References: <1426274503-372191-1-git-send-email-agartrell@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org To: helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1426274503-372191-1-git-send-email-agartrell-b10kYP2dOMg@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Helin, any comment about this trivial patch? 2015-03-13 12:21, Alex Gartrell: > I couldn't figure out why this #ifdef existed so I looked around upstream > and it's not there. It seems to build just fine without it. > > Signed-off-by: Alex Gartrell > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > index a582f52..d58e1f3 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct igb_ring *ring) > return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1; > } > > -#ifdef CONFIG_BQL > static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring) > { > return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index); > } > -#endif /* CONFIG_BQL */ > > // #ifdef EXT_THERMAL_SENSOR_SUPPORT > // #ifdef IGB_PROCFS >