From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] scripts: make load-devel-config not to appear as executable Date: Wed, 24 Aug 2016 18:23:26 +0200 Message-ID: <1487241.9OHH2rcfAT@xps13> References: <1470236340-21752-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CEEA6567B for ; Wed, 24 Aug 2016 18:23:28 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id f65so207074901wmi.0 for ; Wed, 24 Aug 2016 09:23:28 -0700 (PDT) In-Reply-To: <1470236340-21752-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-08-03 16:59, Christian Ehrhardt: > *Updates in v2* > - drop the #!/bin/echo now that it is no more executable > > Quoting the first line of the script: "#! /bin/echo must be loaded with ." > Given that we should drop the .sh file ending as well as the executable > flag - both are not needed to source the file. > > Signed-off-by: Christian Ehrhardt Applied, thanks (despite I disagree with this change ;)