From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chas Williams <3chas3@gmail.com>
Subject: Re: [PATCH v3 02/16] net/avp: public header files
Date: Fri, 03 Mar 2017 09:37:40 -0500
Message-ID: <1488551860.1670.4.camel@gmail.com>
References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-3-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: ian.jolliffe@windriver.com, jerin.jacob@caviumnetworks.com,
 stephen@networkplumber.org, thomas.monjalon@6wind.com, dev@dpdk.org
To: Allain Legacy <allain.legacy@windriver.com>, ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com
 [209.85.220.194]) by dpdk.org (Postfix) with ESMTP id 6A13D37AA
 for <dev@dpdk.org>; Fri,  3 Mar 2017 15:37:42 +0100 (CET)
Received: by mail-qk0-f194.google.com with SMTP id n127so27459299qkf.2
 for <dev@dpdk.org>; Fri, 03 Mar 2017 06:37:42 -0800 (PST)
In-Reply-To: <1488414008-162839-3-git-send-email-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2017-03-01 at 19:19 -0500, Allain Legacy wrote:
> +
> +/**
> + * Memory aligment (cache aligned)

Spelling -- alignment.

> + */
> +#ifndef RTE_AVP_ALIGNMENT
> +#define RTE_AVP_ALIGNMENT 64
> +#endif

This is already provided by DPDK as CONFIG_RTE_CACHE_LINE_SIZE

> + * Defines the number of mbuf pools supported per device (1 per socket)
> + * @note This value should be equal to RTE_MAX_NUMA_NODES
> + */
> +#define RTE_AVP_MAX_MEMPOOLS (8)

Perhaps it should be RTE_MAX_NUMA_NODES then?

> +#define RTE_AVP_MAX_QUEUES (8) /**< Maximum number of queues per device */
> +
> +/** Maximum number of chained mbufs in a packet */
> +#define RTE_AVP_MAX_MBUF_SEGMENTS (5)

The ()'s around constants aren't really necessary.  You aren't going to
get side effects.