From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chas Williams <3chas3@gmail.com>
Subject: Re: [PATCH v3 08/16] net/avp: device initialization
Date: Fri, 03 Mar 2017 10:04:59 -0500
Message-ID: <1488553499.1670.10.camel@gmail.com>
References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-9-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: ian.jolliffe@windriver.com, jerin.jacob@caviumnetworks.com,
 stephen@networkplumber.org, thomas.monjalon@6wind.com, dev@dpdk.org
To: Allain Legacy <allain.legacy@windriver.com>, ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com
 [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 2BA773DC
 for <dev@dpdk.org>; Fri,  3 Mar 2017 16:05:00 +0100 (CET)
Received: by mail-qk0-f193.google.com with SMTP id j127so9563757qke.0
 for <dev@dpdk.org>; Fri, 03 Mar 2017 07:05:00 -0800 (PST)
In-Reply-To: <1488414008-162839-9-git-send-email-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2017-03-01 at 19:20 -0500, Allain Legacy wrote:
> +	/* Check current migration status */
> +	if (avp_dev_migration_pending(eth_dev)) {
> +		PMD_DRV_LOG(ERR, "VM live migration operation in progress\n");
> +		return -EBUSY;
> +	}
> +
> +	/* Check BAR resources */
> +	ret = avp_dev_check_regions(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Failed to validate BAR resources, ret=%d\n",
> +			    ret);
> +		return ret;
> +	}
> +
> +	/* Enable interrupts */
> +	ret = avp_dev_setup_interrupts(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Failed to enable interrupts, ret=%d\n", ret);
> +		return ret;
> +	}

I don't see the other side of this to unregister the callback.  It's also
a bit confusing with this here and the other parts in part 15.  It looks
like you enable the interrupts on .dev_create but disable on .dev_stop?
If that's the case, you likely want to just do the setup here and the
enable in .dev_start.