From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wenfeng Liu Subject: [PATCH] net/virtio-user: fix tapfds close issue Date: Mon, 13 Mar 2017 09:33:21 +0000 Message-ID: <1489397601-2986-1-git-send-email-liuwf@arraynetworks.com.cn> Mime-Version: 1.0 Content-Type: text/plain Cc: To: , Return-path: Received: from mail01.arraynetworks.com.cn (mail.arraynetworks.com.cn [124.42.99.121]) by dpdk.org (Postfix) with ESMTP id 9E4E33B5 for ; Mon, 13 Mar 2017 10:33:27 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The valid tap file descriptor range should be equal or greater than zero instead of non-zero Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Signed-off-by: Wenfeng Liu --- drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c index 05aa6c6..68d28b1 100644 --- a/drivers/net/virtio/virtio_user/vhost_kernel.c +++ b/drivers/net/virtio/virtio_user/vhost_kernel.c @@ -365,7 +365,7 @@ struct vhost_memory_kernel { vhostfd = dev->vhostfds[pair_idx]; if (!enable) { - if (dev->tapfds[pair_idx]) { + if (dev->tapfds[pair_idx] >= 0) { close(dev->tapfds[pair_idx]); dev->tapfds[pair_idx] = -1; } -- 1.8.3.1