From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gage Eads Subject: [PATCH v4] eventdev: add errno-style return values Date: Fri, 17 Mar 2017 09:51:28 -0500 Message-ID: <1489762288-4710-1-git-send-email-gage.eads@intel.com> References: <1489695139-13111-1-git-send-email-gage.eads@intel.com> Cc: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, harry.van.haaren@intel.com, nipun.gupta@nxp.com, "Eads, Gage" To: dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C0667CF90 for ; Fri, 17 Mar 2017 15:52:24 +0100 (CET) In-Reply-To: <1489695139-13111-1-git-send-email-gage.eads@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Eads, Gage" This commit adds rte_errno return values to rte_event_enqueue_burst() and rte_event_dequeue_burst(). These return values allows user software to differentiate between an invalid argument (such as an invalid queue_id or sched_type in an enqueued event) and backpressure from the event device. The port and device ID checks are placed in RTE_LIBRTE_EVENTDEV_DEBUG header guards to avoid the performance hit in non-debug execution. Signed-off-by: Gage Eads --- Changes for v2: - Remove rte_errno initialization Changes for v3: - Fix checkpatch and check-git-log.sh errors Changes for v4: - v3 was incorrectly based on v1, v4 is instead based on v2's changes lib/librte_eventdev/rte_eventdev.h | 40 +++++++++++++++++++++++++++++++++++--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index 2b30a35..a45c81a 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_eventdev/rte_eventdev.h @@ -245,6 +245,7 @@ extern "C" { #include #include +#include struct rte_mbuf; /* we just use mbuf pointers; no need to include rte_mbuf.h */ @@ -1118,9 +1119,14 @@ rte_event_schedule(uint8_t dev_id) * The number of event objects actually enqueued on the event device. The * return value can be less than the value of the *nb_events* parameter when * the event devices queue is full or if invalid parameters are specified in a - * *rte_event*. If return value is less than *nb_events*, the remaining events - * at the end of ev[] are not consumed,and the caller has to take care of them - * + * *rte_event*. If the return value is less than *nb_events*, the remaining + * events at the end of ev[] are not consumed and the caller has to take care + * of them, and rte_errno is set accordingly. Possible errno values include: + * -(-EINVAL) The port ID is invalid, device ID is invalid, an event's queue + * ID is invalid, or an event's sched type doesn't match the + * capabilities of the destination queue. + * -(-ENOSPC) The event port was backpressured and unable to enqueue + * one or more events. * @see rte_event_port_enqueue_depth() */ static inline uint16_t @@ -1129,6 +1135,20 @@ rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id, { struct rte_eventdev *dev = &rte_eventdevs[dev_id]; +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG + if (rte_eventdevs[dev_id].attached == RTE_EVENTDEV_DETACHED) { + RTE_EDEV_LOG_DEBUG("Invalid dev_id=%d\n", dev_id); + rte_errno = -EINVAL; + return 0; + } + + if (port_id >= dev->data->nb_ports) { + RTE_EDEV_LOG_DEBUG("Invalid port_id=%d\n", port_id); + rte_errno = -EINVAL; + return 0; + } +#endif + /* * Allow zero cost non burst mode routine invocation if application * requests nb_events as const one @@ -1239,6 +1259,20 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[], { struct rte_eventdev *dev = &rte_eventdevs[dev_id]; +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG + if (rte_eventdevs[dev_id].attached == RTE_EVENTDEV_DETACHED) { + RTE_EDEV_LOG_DEBUG("Invalid dev_id=%d\n", dev_id); + rte_errno = -EINVAL; + return 0; + } + + if (port_id >= dev->data->nb_ports) { + RTE_EDEV_LOG_DEBUG("Invalid port_id=%d\n", port_id); + rte_errno = -EINVAL; + return 0; + } +#endif + /* * Allow zero cost non burst mode routine invocation if application * requests nb_events as const one -- 2.7.4