From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/3] examples/distributor: fix build for
	non-x86	arch
Date: Fri, 05 Feb 2016 16:55:28 +0100
Message-ID: <1492687.rAoTrH7ulh@xps13>
References: <1454684049-27195-1-git-send-email-thomas.monjalon@6wind.com>
 <3AEA2BF9852C6F48A459DA490692831FFBEB4C@IRSMSX109.ger.corp.intel.com>
 <2601191342CEEE43887BDE71AB97725836B0465D@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id C7B82B47D
 for <dev@dpdk.org>; Fri,  5 Feb 2016 16:56:45 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id p63so33127729wmp.1
 for <dev@dpdk.org>; Fri, 05 Feb 2016 07:56:45 -0800 (PST)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B0465D@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-02-05 15:15, Ananyev, Konstantin:
> From: Pattan, Reshma
> > From: Thomas Monjalon
> > > _mm_prefetch is defined only in x86 compilers.
> > > rte_prefetch functions are defined in EAL for each arch, and must be preferred
> > > over compiler intrinsics.
[...]
> > > -			_mm_prefetch((void *)bufs[0], 0);
> > > -			_mm_prefetch((void *)bufs[1], 0);
> > > -			_mm_prefetch((void *)bufs[2], 0);
> > > +			rte_prefetch0((void *)bufs[0]);
> > > +			rte_prefetch0((void *)bufs[1]);
> > > +			rte_prefetch0((void *)bufs[2]);
> > 
> > Some time back Jerin Jacob has sent patch for replacing the _mm_prefetch  with rte_prefetch_non_temporal. This is FYI.
> 
> Yep:
> http://dpdk.org/dev/patchwork/patch/9369/
> http://dpdk.org/dev/patchwork/patch/9370/
> 
> And on IA _mm_prefetch(p, 0) != rte_prefetch0(p).
> I think, as in Jacob implementation, it should be PREFETCHNTA.

Oh yes, you're right. Thanks
patch rejected