From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Miller Subject: [PATCH 4/4] net/ark: fix return value of null not checked Date: Tue, 16 May 2017 12:14:18 -0400 Message-ID: <1494951258-11232-4-git-send-email-john.miller@atomicrules.com> References: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> Cc: ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller To: dev@dpdk.org Return-path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 4569D2BFF for ; Tue, 16 May 2017 18:14:30 +0200 (CEST) Received: by mail-qt0-f196.google.com with SMTP id l39so21493269qtb.1 for ; Tue, 16 May 2017 09:14:30 -0700 (PDT) In-Reply-To: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 144517 Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville") Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index f8fb359..017817e 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -899,6 +899,12 @@ static void eth_ark_macaddr_remove(struct rte_eth_dev *dev, int size = 0; int first = 1; + if (file == NULL) { + PMD_DRV_LOG(ERR, "Unable to open " + "config file %s\n", value); + return -1; + } + while (fgets(line, sizeof(line), file)) { size += strlen(line); if (size >= ARK_MAX_ARG_LEN) { -- 1.9.1