From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qi Zhang Subject: [PATCH v3 1/3] net/ixgbe: remove reduandent code Date: Thu, 1 Jun 2017 13:36:43 -0400 Message-ID: <1496338605-7338-2-git-send-email-qi.z.zhang@intel.com> References: <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com> <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com> Cc: dev@dpdk.org, Qi Zhang To: wenzhuo.lu@intel.com, helin.zhang@intel.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1AA4A7CE3 for ; Fri, 2 Jun 2017 02:43:25 +0200 (CEST) In-Reply-To: <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove reduandent code. item->type != RTE_FLOW_ITEM_TYPE_END already cover item->type == RTE_FLOW_ITEM_TYPE_VLAN. Signed-off-by: Qi Zhang --- v3: -fix comments. drivers/net/ixgbe/ixgbe_flow.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index da7b1cc..60ca8d8 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -1544,18 +1544,10 @@ ixgbe_parse_fdir_filter_normal(const struct rte_flow_attr *attr, rule->mask.vlan_tci_mask &= rte_cpu_to_be_16(0xEFFF); /* More than one tags are not supported. */ - /** - * Check if the next not void item is not vlan. - */ + /* Next not void item must be END */ index++; NEXT_ITEM_OF_PATTERN(item, pattern, index); - if (item->type == RTE_FLOW_ITEM_TYPE_VLAN) { - memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); - rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ITEM, - item, "Not supported by fdir filter"); - return -rte_errno; - } else if (item->type != RTE_FLOW_ITEM_TYPE_END) { + if (item->type != RTE_FLOW_ITEM_TYPE_END) { memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, -- 2.7.4