From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wang Subject: [PATCH] net/i40e: fix param check to avoid division by 0 Date: Mon, 12 Jun 2017 05:07:00 -0400 Message-ID: <1497258420-11814-1-git-send-email-wang.yong19@zte.com.cn> Cc: dev@dpdk.org, Yong Wang To: helin.zhang@intel.com, jingjing.wu@intel.com Return-path: Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 560599E3 for ; Mon, 12 Jun 2017 11:18:12 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0, 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by adding a check to parameter 'enabled_tcmap'. Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index c18a93b..d41b213 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4257,6 +4257,11 @@ enum i40e_status_code int i, total_tc = 0; uint16_t qpnum_per_tc, bsf, qp_idx; + if (enabled_tcmap == 0) { + PMD_DRV_LOG(ERR, "Error! enabled tcmap shouldn't be 0"); + return I40E_ERR_PARAM; + } + ret = validate_tcmap_parameter(vsi, enabled_tcmap); if (ret != I40E_SUCCESS) return ret; -- 1.8.3.1