From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] check-symbol-change: fix regex to match on
	end of map file
Date: Sun, 18 Nov 2018 23:25:21 +0100
Message-ID: <14977941.BcdJQmDsnJ@xps>
References: <20181101135410.15945-1-nhorman@tuxdriver.com>
 <3649242.bmXl2ZTEod@xps>
 <20181102115045.GA31972@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, doucette@bu.edu
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0F15B2B83
 for <dev@dpdk.org>; Sun, 18 Nov 2018 23:25:25 +0100 (CET)
In-Reply-To: <20181102115045.GA31972@hmswarspite.think-freely.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/11/2018 12:50, Neil Horman:
> On Thu, Nov 01, 2018 at 11:53:00PM +0100, Thomas Monjalon wrote:
> > 01/11/2018 14:54, Neil Horman:
> > > the regex to determine the end of the map file chunk in a patch seems to
> > > be wrong,  It was using perl regex syntax, which awk doesn't appear to
> > > support (I'm still not sure how it was working previously).  Regardless,
> > > it wasn't triggering and as a result symbols were getting added to the
> > > mapdb that shouldn't be there.
> > > 
> > > Fix it by converting the regex to use traditional posix syntax, matching
> > > only on the negation of the character class [^map]
> > > 
> > > Tested and shown to be working on the ip_frag patch set provided by
> > > doucette@bu.edu
> > > 
> > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > > CC: thomas@monjalon.net
> > > CC: doucette@bu.edu
> > > Reported-by: doucette@bu.edu
> > 
> > You could use these lines:
> > 
> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > 
> > Reported-by: Cody Doucette <doucette@bu.edu>
> > 
> I'm fine with the second line, and the first is fine I guess, but I'm not sure
> there is an exact correlation
> 
> > > --- a/devtools/check-symbol-change.sh
> > > +++ b/devtools/check-symbol-change.sh
> > > -		/[-+] a\/.*\.^(map)/ {in_map=0}
> > > +		/[-+] a\/.*\.[^map]/ {in_map=0}
> > 
> > Not sure this is what you intend:
> > [^map] means any character except "m", "a" and "p".
> > 
> Its not 100%, but its pretty close.  The regex for exact matching on not a
> specific string is pretty large and complex.  Since we have no files that that
> end in .m .a or .p, this should give us what we want for the forseeable future.
> 
> > I don't know whether awk supports this syntax: (?!foo)
> > 
> It unfortunately doesn't, thats perl syntax, and while grep I think supports it,
> awk is more strictly posix compliant.

I understand now.

Applied, thanks