From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ethdev: fix applications failure on configure
Date: Tue, 01 May 2018 16:01:42 +0200
Message-ID: <14979049.G4nOY0bchV@xps>
References: <20180501133343.125260-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>, xuemingl@mellanox.com
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 433BE200
 for <dev@dpdk.org>; Tue,  1 May 2018 16:01:45 +0200 (CEST)
In-Reply-To: <20180501133343.125260-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/05/2018 15:33, Ferruh Yigit:
> Many sample applications fail because of
> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()

We need to define the API behaviour in doxygen.

> The sample applications need to be fixed/updated before returning error
> on rte_eth_dev_configure()
> 
> This patch keeps the error log but removes returning error.

If the doc is updated in 18.05, we can have a deprecation notice
to insert the error return in 18.08.

> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> Cc: xuemingl@mellanox.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>