From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Wang Subject: [PATCH v2] net/fm10k: initialize link status in device start Date: Thu, 22 Jun 2017 04:20:03 -0700 Message-ID: <1498130403-121027-1-git-send-email-xiao.w.wang@intel.com> References: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org, stable@dpdk.org, Xiao Wang To: jing.d.chen@intel.com Return-path: In-Reply-To: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fm10k host driver can't manage PHY directly and provides a fake link status by always reporting LINK_UP. We should initialize link status in device start, otherwise application will get LINK_DOWN status when LSC configured. Fixes: 9ae6068c86da ("fm10k: add dev start/stop") Cc: stable@dpdk.org Signed-off-by: Xiao Wang --- v2: * Rewrite commit message, add information about fm10k PHY. * Always do link_update in dev_start. --- drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 7172a0f..c5c4712 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -84,6 +84,8 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev *dev, static void fm10k_set_rx_function(struct rte_eth_dev *dev); static void fm10k_set_tx_function(struct rte_eth_dev *dev); static int fm10k_check_ftag(struct rte_devargs *devargs); +static int fm10k_link_update(struct rte_eth_dev *dev, + __rte_unused int wait_to_complete); struct fm10k_xstats_name_off { char name[RTE_ETH_XSTATS_NAME_SIZE]; @@ -1166,6 +1168,8 @@ static inline int fm10k_glort_valid(struct fm10k_hw *hw) if (!(dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG)) fm10k_vlan_filter_set(dev, hw->mac.default_vid, true); + fm10k_link_update(dev, 0); + return 0; } -- 1.8.3.1