From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chas Williams <3chas3@gmail.com>
Subject: Re: [PATCH] net/bond: change link status check to no-wait
Date: Mon, 26 Jun 2017 16:53:45 -0400
Message-ID: <1498510425.1841.0.camel@gmail.com>
References: <20170626151347.16680-1-declan.doherty@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com
 [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 13991374
 for <dev@dpdk.org>; Mon, 26 Jun 2017 22:53:48 +0200 (CEST)
Received: by mail-qk0-f193.google.com with SMTP id p21so1665556qke.0
 for <dev@dpdk.org>; Mon, 26 Jun 2017 13:53:47 -0700 (PDT)
In-Reply-To: <20170626151347.16680-1-declan.doherty@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote:
> In the 802.3ad periodic callback function the link status of all slaves
> is checked using rte_eth_link_get function. Depending on the slave 
> device this function can block for up to 9 seconds and therefore
> could cause issues with the LACP Daemon state machine and control
> patches handling. This patch changes to the no-wait version of
> the link get function.
> 
> Fixes: 46fb4368 ("bond:add mode 4")
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index d2b7592..3a97336 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -758,7 +758,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
>  		uint16_t key;
>  
>  		slave_id = internals->active_slaves[i];
> -		rte_eth_link_get(slave_id, &link_info);
> +		rte_eth_link_get_nowait(slave_id, &link_info);
>  		rte_eth_macaddr_get(slave_id, &slave_addr);
>  
>  		if (link_info.link_status != 0) {

It seems like this should be done in bandwidth_left() as well.