From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: [PATCH 2/2] testpmd: give more hint on invalid RETA size Date: Fri, 7 Jul 2017 14:02:13 +0800 Message-ID: <1499407333-1682-2-git-send-email-yliu@fridaylinux.org> References: <1499407333-1682-1-git-send-email-yliu@fridaylinux.org> Cc: Jingjing Wu , Yuanhan Liu To: dev@dpdk.org Return-path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id CB9F52C8 for ; Fri, 7 Jul 2017 08:02:56 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id e199so3216704pfh.0 for ; Thu, 06 Jul 2017 23:02:56 -0700 (PDT) In-Reply-To: <1499407333-1682-1-git-send-email-yliu@fridaylinux.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Print the valid RTE size range so that user knows what goes wrong. Signed-off-by: Yuanhan Liu --- app/test-pmd/cmdline.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c8faef9..d32a1df 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2140,12 +2140,14 @@ cmd_showport_reta_parsed(void *parsed_result, struct cmd_showport_reta *res = parsed_result; struct rte_eth_rss_reta_entry64 reta_conf[8]; struct rte_eth_dev_info dev_info; + uint16_t max_reta_size; memset(&dev_info, 0, sizeof(dev_info)); rte_eth_dev_info_get(res->port_id, &dev_info); - if (dev_info.reta_size == 0 || res->size > dev_info.reta_size || - res->size > ETH_RSS_RETA_SIZE_512) { - printf("Invalid redirection table size: %u\n", res->size); + max_reta_size = RTE_MIN(dev_info.reta_size, ETH_RSS_RETA_SIZE_512); + if (res->size == 0 || res->size > max_reta_size) { + printf("Invalid redirection table size: %u (1-%u)\n", + res->size, max_reta_size); return; } -- 2.7.4