From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v11 0/5] link bonding library
Date: Wed, 02 Jul 2014 00:01:42 +0200
Message-ID: <1499740.ex9F3ntLKi@xps13>
References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com>
 <13010138.0NjEKNQfRt@xps13>
 <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Doherty, Declan" <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-06-30 09:28, Doherty, Declan:
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 
> > Hi Declan,
> > 
> > 2014-06-29 18:49, Declan Doherty:
> > > This patchset contains the name change fix in the link bonding library
> > > makefile. I have also put a change into the unit test application
> > > makefile
> > > so that the link bonding tests are not built if the library is also not
> > > being built. It doesn't make sense to split the bonding libraries APIs
> > > into
> > > a seperate library, as they are directly coupled to with the bonding
> > > library implmentation
> > 
> > You fixed optional building but there is still an issue when building
> > shared library.
> > As you don't want to split the library to separate the PMD plugin from the
> > specific API, I suggest to not consider it as a plugin (unlike other
> > PMDs).
> > 
> > I've sent some patches about these 2 topics.
> > If you agree, I'll apply them, merged with your serie.
> 
> I'm happy for you to apply the makefile changes you have suggested and not
> consider the bonding PMD as a plugin, I  think this makes the most sense
> considering it is a purely software library.

Applied with Robert's changes for version 1.7.0.

Thanks for all these revisions (v11 is currently the best score :)
-- 
Thomas