From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v2 11/18] devargs: simplify implementation Date: Tue, 17 Oct 2017 11:28:24 +0530 Message-ID: <149a30e6-9377-2c2f-9df6-ac32f5f024d0@nxp.com> References: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> <39e734ea-531c-6335-f1d5-22c75fe38f9e@nxp.com> <4f3a6e5e-65ea-4cef-1146-3b91943ec5c7@nxp.com> <20171016134216.GD3408@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0050.outbound.protection.outlook.com [104.47.34.50]) by dpdk.org (Postfix) with ESMTP id 04A7E1B70B for ; Tue, 17 Oct 2017 07:46:19 +0200 (CEST) In-Reply-To: <20171016134216.GD3408@bidouze.vm.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Gaetan, On Monday 16 October 2017 07:12 PM, Gaëtan Rivet wrote: > On Mon, Oct 16, 2017 at 05:12:37PM +0530, Shreyansh Jain wrote: >> Hello Gaetan, >> >> Please ignore this email (reason inline) >> > > Hello Shreyansh, > > Thanks for reading this patchset, and sorry about the confusion (the > previous cover-letter only listed the PCI bus move, the bus control was > only added in this version). That's OK. I mixed up the cover-letters anyway. Probably the complete series needs a rebase as some patches have changes exactly same locations in EAL where this patch impacts (at least for PCI movement patches, I found patches had fuzz factor) > > I'd be very happy to see these series integrated for this release or the > next, and as such your opinion would matter a great deal. I do understand the importance of this patch series - but I have not been able to devote enough time to this lately. Even now, I am not sure if I would be able to completely review all within 17.11 timeframe as it is quite big. (And I have some personal time-off coming up soon!) > > However, I have found important issues that I am still working on with > the PCI bus move. I am trying to fix this in time, but I'm not sure yet > to succeed soon enough. I understand. It is a complex series - specially the build break in PCI movement on per patch basis - that would be difficult to solve. Probably that requires adding dummy functions/variables to allow compilation and then moving them out. It is indeed tough choice. > > It would block the rest. I could still redo both series without the PCI > bus move but the bus control scheme is necessary for the devargs > cleanup. Probably it is best to postpone for 18.02. It indeed is difficult to let a proposal fall through a planned release - but this work is really critical as it impacts a lot of people (PCI, Buses, args etc). Just my personal opinion. > > I don't know if this bus control scheme is interesting enough though. > I need additional opinions about it. I haven't started reading the Bus control yet - I am still focusing on PCI movement and then I had planned the devargs. But, I will start looking into this as well. I would try to add whatever opinion I can. > > Anyway, thanks, > Always welcome! But, that's what the community is for. :D - Shreyansh