Re: [PATCH v2] dev: fix hotplug notification to secondary

[fengchengwen <fengchengwen@huawei.com>]

Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>

On 7/7/2026 7:55 PM, David Marchand wrote:
> There was a logical error when making some last minute change.
> Fix the no_shconf evaluation.
> 
> Bugzilla ID: 1963
> Fixes: 1a2e26d8701d ("dev: skip multi-process in hotplug")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - separated the unit test from the fix,
> 
> ---
>  lib/eal/common/eal_common_dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c
> index 9ed62a20e0..b43b0a4bb3 100644
> --- a/lib/eal/common/eal_common_dev.c
> +++ b/lib/eal/common/eal_common_dev.c
> @@ -269,7 +269,7 @@ rte_dev_probe(const char *devargs)
>  {
>  	const struct internal_config *internal_conf =
>  		eal_get_internal_configuration();
> -	bool do_mp = !!internal_conf->no_shconf;
> +	bool do_mp = internal_conf->no_shconf == 0;
>  	struct eal_dev_mp_req req;
>  	struct rte_device *dev;
>  	int ret;
> @@ -428,7 +428,7 @@ rte_dev_remove(struct rte_device *dev)
>  {
>  	const struct internal_config *internal_conf =
>  		eal_get_internal_configuration();
> -	bool do_mp = !!internal_conf->no_shconf;
> +	bool do_mp = internal_conf->no_shconf == 0;
>  	struct eal_dev_mp_req req;
>  	char *devargs;
>  	int ret;