From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3 3/9] mem: fix potential double close Date: Fri, 27 Apr 2018 17:56:46 +0100 Message-ID: <14e3fed3-9f9a-ad4d-4ccc-8f33f9cd1a41@intel.com> References: <20180427151554.GC80648@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, thomas@monjalon.net To: Bruce Richardson Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C7AAD8E85 for ; Fri, 27 Apr 2018 18:56:50 +0200 (CEST) In-Reply-To: <20180427151554.GC80648@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27-Apr-18 4:15 PM, Bruce Richardson wrote: > On Wed, Apr 25, 2018 at 10:56:41AM +0100, Anatoly Burakov wrote: >> We were closing descriptor before checking if mapping has >> failed, but if it did, we did a second close afterwards. Fix >> it by moving closing descriptor to after we check if mmap has >> succeeded. >> >> Coverity issue: 272560 >> >> Fixes: 2a04139f66b4 ("eal: add single file segments option") >> Cc: anatoly.burakov@intel.com >> >> Signed-off-by: Anatoly Burakov >> --- > Is a better fix not to assign fd to -1 after closing and then checking that > in the error leg? > A betterer fix would've been to move close() to until after all errors are checked. Will do that instead :) -- Thanks, Anatoly