From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v6 1/2] ethdev: remove get_reg_length callback Date: Mon, 4 Jul 2016 14:24:08 +0100 Message-ID: <14eca081-0333-53f8-eb7c-1aa89c44df56@intel.com> References: <1466688410-13826-1-git-send-email-zr@semihalf.com> <1467632207-13809-1-git-send-email-zr@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Zyta Szpak , thomas.monjalon@6wind.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jerin.jacob@caviumnetworks.com, rahul.lakkireddy@chelsio.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 022912BA9 for ; Mon, 4 Jul 2016 15:24:11 +0200 (CEST) In-Reply-To: <1467632207-13809-1-git-send-email-zr@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/07/2016 12:36, Zyta Szpak wrote: > From: Zyta Szpak > > Removes hard-coded assumption that device registers > are always 32 bits wide. The rte_eth_dev_get_reg_length > and rte_eth_dev_get_reg_info callbacks did not > provide register size to the app in any way while is > needed to allocate correct number of bytes before > retrieving registers using rte_eth_dev_get_reg. > > This commit changes rte_eth_dev_get_reg_info so that > it can be used to retrieve both the number of registers > and their width, and removes the now-redundant > rte_eth_dev_get_reg_length. > > Signed-off-by: Zyta Szpak Acked-by: Remy Horton