From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hunt Subject: [PATCH v2] net/i40e: fix sync phy type by adding retry Date: Mon, 24 Jul 2017 09:48:44 +0100 Message-ID: <1500886124-19379-1-git-send-email-david.hunt@intel.com> References: <1500648081-210705-1-git-send-email-david.hunt@intel.com> Cc: jingjing.wu@intel.com, stable@dpdk.org, David Hunt To: dev@dpdk.org Return-path: In-Reply-To: <1500648081-210705-1-git-send-email-david.hunt@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some phy's take longer than others to come up. Add a retry to give more phy's a chance to come up before returning an error. Fixes: 2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus SFP") Signed-off-by: David Hunt --- drivers/net/i40e/i40e_ethdev.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 97a73e1..8c39eb7 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -9248,16 +9248,22 @@ i40e_dev_sync_phy_type(struct i40e_hw *hw) enum i40e_status_code status; struct i40e_aq_get_phy_abilities_resp phy_ab; int ret = -ENOTSUP; + int retries = 0; status = i40e_aq_get_phy_capabilities(hw, false, true, &phy_ab, NULL); - if (status) { + while (status) { PMD_INIT_LOG(WARNING, "Failed to sync phy type: status=%d", status); - return ret; + retries++; + rte_delay_us(100000); + if (retries < 5) + status = i40e_aq_get_phy_capabilities(hw, false, + true, &phy_ab, NULL); + else + return ret; } - return 0; } -- 2.7.4