From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] ethdev: fix DCB config issue on ixgbe
Date: Thu, 30 Jun 2016 09:41:57 +0200
Message-ID: <1501713.7uhgKcRiBR@xps13>
References: <1460363050-27962-1-git-send-email-wenzhuo.lu@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09090348A2BD@shsmsx102.ccr.corp.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 0F0D32C0B
 for <dev@dpdk.org>; Thu, 30 Jun 2016 09:42:03 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id a66so105253054wme.0
 for <dev@dpdk.org>; Thu, 30 Jun 2016 00:42:03 -0700 (PDT)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-30 01:40, Lu, Wenzhuo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-06-23 01:04, Lu, Wenzhuo:
> > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > > 2016-05-06 05:33, Wenzhuo Lu:
> > > > > > +int
> > > > > > +rte_eth_dev_mq_mode_set(uint8_t port_id,
> > > > > > +			enum rte_eth_rx_mq_mode rx_mq_mode,
> > > > > > +			enum rte_eth_tx_mq_mode tx_mq_mode);
> > > > >
> > > > > I've really tried to think about it and I think it is more or less a hack.
> > > > > First, it is not explained in the doc when we should use
> > > > > rte_eth_dev_mq_mode_set() instead of a simple call to
> > > rte_eth_dev_configure().
> > > > > Second, I don't understand why having a function which configures
> > > > > the "multiqueue modes" without configuring properly RSS/VMDq/DCB.
> > > > > Last, it is said that rte_eth_dev_configure() "must be invoked
> > > > > first before any other function in the Ethernet API".
> After checking the code, Honestly I'm confused. I don't find this description.

It's in the description of rte_eth_dev_configure():
	http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n1904

> And on the contrary, I find rte_eth_dev_info_get is always called before
> rte_eth_dev_configure. I believe it's the problem.
> As rte_eth_dev_configure is not run, rte_eth_dev_info_get cannot get the right info.
> That why I have to add a API to set the mq_mode before rte_eth_dev_info_get.
> Does that mean all the related examples are wrong? Any opinion? Thanks.

My opinion is that this area needs a good cleanup and easy API :)