From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <luca.boccassi@gmail.com>
Subject: Re: [PATCH v4 0/6] Reproducible build
Date: Fri, 11 Aug 2017 13:43:05 +0100
Message-ID: <1502455385.31114.2.camel@gmail.com>
References: <20170623184153.24488-1-lboccass@brocade.com>
 <20170628135702.18150-1-lboccass@brocade.com>
 <20170628085733.10153207@xeon-e3>
 <20170628160409.GA7876@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>, Stephen Hemminger
 <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 3E2675699
 for <dev@dpdk.org>; Fri, 11 Aug 2017 14:43:07 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id r77so6381379wmd.2
 for <dev@dpdk.org>; Fri, 11 Aug 2017 05:43:07 -0700 (PDT)
In-Reply-To: <20170628160409.GA7876@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2017-06-28 at 17:04 +0100, Bruce Richardson wrote:
> On Wed, Jun 28, 2017 at 08:57:33AM -0700, Stephen Hemminger wrote:
> > On Wed, 28 Jun 2017 14:56:56 +0100
> > <lboccass@brocade.com> wrote:
> >=20
> > > From: Luca Boccassi <luca.boccassi@gmail.com>
> > >=20
> > > In the past couple of years a concerted effort among almost all
> > > Linux
> > > distros has been striving toward achieving reproducible builds.
> > > [1]
> > > This involves changes to the toolchain, new tools and CI systems.
> > > [2]
> > >=20
> > > v1 fixed the documentation, examples and linker script
> > > generation.
> > > v2 fixes all problems, which were caused by unstable order of
> > > headers
> > > inclusion, source files listing and object file listing when
> > > passing
> > > them to the compiler.
> > > DPDK's build, at least with the default configuration, is fully
> > > reproducible with this patch series as tested by the Reproducible
> > > Builds developers experimental toolchain. [3]
> > >=20
> > > v3 restores the first patch, which was eaten by git send-email.
> > >=20
> > > v4 drops the patch that reorders rebuilds, and adds a patch to
> > > make
> > > the inclusion of headers deterministic with regards to GCC
> > > embedding
> > > the full file path when expading __FILE__ and when writing the
> > > directory listing in the DWARF objects.
> > > It also drops the first 2 patches which have already been merged.
> > >=20
> > > [1] https://reproducible-builds.org/
> > > [2] https://reproducible-builds.org/tools/
> > > [3] https://wiki.debian.org/ReproducibleBuilds/ExperimentalToolch
> > > ain#Us
> >=20
> > Looks good.
> >=20
> > Looking ahead, how does this work with the proposed new build
> > system?
> > Is there an automated way to check new submissions so that new
> > features
> > don't undo this.
> >=20
> >=20
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>=20
> http://mesonbuild.com/Reproducible-builds.html
>=20
> I'd hope if we switch build system, this shouldn't be a problem. It's
> definitely something to watch out for.
>=20
> /Bruce

The one issue to look for, with the current build system, is the CFLAGS
include path order (the last patch) in the makefiles under lib/

The pattern seems to be always the same, would it be possible &
acceptable to add a check in checkpatch?

bad:
CFLAGS +=3D -I$(SRCDIR)

good:
CFLAGS :=3D -I$(SRCDIR) $(CFLAGS)

--=20
Kind regards,
Luca Boccassi