From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rongqiang XIE Subject: [PATCH] net/qede:fix the bug about pointer params may NULL Date: Thu, 24 Aug 2017 15:12:33 +0800 Message-ID: <1503558753-8545-1-git-send-email-xie.rongqiang@zte.com.cn> Cc: dev@dpdk.org, Rongqiang XIE To: rasesh.mody@cavium.com Return-path: Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 2331A7D3A for ; Thu, 24 Aug 2017 09:13:38 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function qede_rss_reta_update(),the pointer params returned from call to function rte_zmalloc() may be NULL and will be dereferenced. So, should judge the params is NULL or not. Signed-off-by: Rongqiang XIE --- drivers/net/qede/qede_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 0e05989..4e9e89f 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev *eth_dev, memset(&vport_update_params, 0, sizeof(vport_update_params)); params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns, RTE_CACHE_LINE_SIZE); + if (params == NULL) { + DP_ERR(edev, "failed to allocate memory\n"); + return -ENOMEM; + } for (i = 0; i < reta_size; i++) { idx = i / RTE_RETA_GROUP_SIZE; -- 1.8.3.1